aerospace: remove broken on-window-detected option

[leon-erd]

Description

As stated here the on-window-detected option is broken.
Right now if you try to add the plain toml of on-window-detected to the extraConfig option you will get an error because the default value of the nix module option will additionally insert a on-window-detected = [] line into the toml.

@damidoug

Checklist

• Change is backwards compatible.

• Code formatted with nix fmt or
  nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

• Code tested through nix run .#tests -- test-all or
  nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.
  • Generate a news entry. See News
  • Basic tests added. See Tests

• If this PR adds an exciting new feature or contains a breaking change.

  • Generate a news entry. See News

[khaneliman]

@damidoug any concerns? Seems like it was just a freeform option definition so shouldn't affect any user's who have it configured. Just removes a confusing definition if it doesn't actually generate properly.

[damidoug]

Yes we can remove that option.

I was honestly thinking to remove all predefined options and leave just a plain "settings ={}" so the user can add any setting without issues.. what do you think @khaneliman ?

[khaneliman]

Yes we can remove that option.

I was honestly thinking to remove all predefined options and leave just a plain "settings ={}" so the user can add any setting without issues.. what do you think @khaneliman ?

Yeah, that’s fine with me

[damidoug]

@leon-erd If you want to proceed with my comment above, I recommend just to keep the 'start-at-login = false' to avoid conflicts with launchd.

I think that's the best way to avoid future errors.