Skip to content

Conversation

@leiserfg
Copy link
Contributor

Description

Adds service for vecinae.
The code is mostly verbatim from https://github.com/vicinaehq/vicinae/blob/main/nix/vicinae.nix
with the main difference that I moved the logic for packaging extensions into the module itself.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@leiserfg
Copy link
Contributor Author

@schromp I'm tagging you so you are aware.

Copy link
Collaborator

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some stuff to follow our latest patterns.

@leiserfg
Copy link
Contributor Author

leiserfg commented Nov 1, 2025

Thanks for the review @khaneliman

@leiserfg
Copy link
Contributor Author

leiserfg commented Nov 2, 2025

Given that auto-starting is optional, should I move this to programs instead of services ?

@khaneliman
Copy link
Collaborator

Given that auto-starting is optional, should I move this to programs instead of services ?

Yeah probably could make more sense that way

@khaneliman
Copy link
Collaborator

Could you add some basic tests and a news entry, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants