-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
vicinae service: init #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
vicinae service: init #8093
Conversation
|
@schromp I'm tagging you so you are aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some stuff to follow our latest patterns.
Co-authored-by: Austin Horstman <[email protected]>
|
Thanks for the review @khaneliman |
|
Given that auto-starting is optional, should I move this to programs instead of services ? |
dcbdfd0 to
cc83703
Compare
Yeah probably could make more sense that way |
|
Could you add some basic tests and a news entry, please. |
Description
Adds service for vecinae.
The code is mostly verbatim from https://github.com/vicinaehq/vicinae/blob/main/nix/vicinae.nix
with the main difference that I moved the logic for packaging extensions into the module itself.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.