rclone: add option to set log-level

[pastamoe]

Description

Add an option to set rclone's log-level per mount:

programs.rclone.remotes.<name>.mounts.<name>.logLevel = "DEBUG";

If no value is set, it'll use rclone's implicit default ("NOTICE")

Previously, the debug log-level got enforced (via "-vv"), which caused noisy logs, and there was no easy way to change that.

Note: rclone global-flags can't be configured in the config file. So, this uses the environment variable approach.

references:

• https://rclone.org/docs/#logging
• https://rclone.org/docs/#v-vv-verbose

Checklist

• Change is backwards compatible.

• Code formatted with nix fmt or
  nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

• Code tested through nix run .#tests -- test-all or
  nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.
  • Generate a news entry. See News
  • Basic tests added. See Tests

• If this PR adds an exciting new feature or contains a breaking change.

  • Generate a news entry. See News

[pastamoe]

Side note: there are no tests for this module yet, so I didn't "modify" any. But I tested the behavior of this change on my machine.

[EDIT] I found the standalone tests now, but I'm not sure how to cover this yet

[khaneliman]

Change makes sense to me, as long as @ttrssreal doesn't have any concerns.

[ttrssreal]

Can we move the new option to the mounts submodule? as its specific to the mount systemd services.

[pastamoe]

Can we move the new option to the mounts submodule? as its specific to the mount systemd services.

Good point! I'll move it

[pastamoe]

Moved the option and updated the commit/PR description.
I also changed the default log level to "NOTICE", as that's what rclone would use when no setting is given, and "INFO" is still a bit too spammy for normal operations IMO.

WDYT?

[khaneliman]

imo I'd prefer most settings that have an application default behavior don't have a configuration default so that a user gets the default app behavior.

[pastamoe]

imo I'd prefer most settings that have an application default behavior don't have a configuration default so that a user gets the default app behavior.

So, should I remove default=..., and if no value is set, the "RCLONE_LOG_LEVEL" shouldn't be put inside the service definition? Am I getting this right?

[khaneliman]

something like this

[ttrssreal]

I agree with @khaneliman about using the application default here. Looks good otherwise, logging should definitely be configurable. Thanks for the PR!

[pastamoe]

Thx for the support! I applied the suggestions of @khaneliman and updated commit and PR description (also removed the mention of the default from the title, to prevent confusion later on)