Issue a warning if we are falling back to the old shell environment #487
Conversation
| @@ -326,6 +326,7 @@ use_flake() { | |||
| # which is probably more useful than nothing. | |||
| # Fallback to use that (which means just leaving profile_rc alone!) | |||
| _nix_direnv_warning "Evaluating current devShell failed. Falling back to previous environment!" | |||
| export NIX_DIRENV_DID_FALLBACK=1 | |||
There was a problem hiding this comment.
Who is the consumer of this environment variable?
|
This is expected to be exported to the calling shell for possible user consumption
…-------- Original Message --------
On 4/20/24 7:17 PM, Jörg Thalheim wrote:
@Mic92 commented on this pull request.
---------------------------------------------------------------
In [direnvrc](#487 (comment)):
> @@ -326,6 +326,7 @@ use_flake() {
# which is probably more useful than nothing.
# Fallback to use that (which means just leaving profile_rc alone!)
_nix_direnv_warning "Evaluating current devShell failed. Falling back to previous environment!"
+ export NIX_DIRENV_DID_FALLBACK=1
Who is the consumer of this environment variable?
—
Reply to this email directly, [view it on GitHub](#487 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAFH2EA5YA3AHXLMT4ANHSTY6LZP5AVCNFSM6AAAAABGPX4346VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGE4DSMBQHA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Ok. Do you have a concrete use case for it? If so it would be nice to put in the Readme. |
|
No - I don't have a concrete use case for this variable, but @amarshall suggested it and it seemed perfectly reasonable to provide an extension point for user consumption here. I have updated the README to note the environment variable. Additionally, I've changed the note about |
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
This should resolve #486.