lib: standardize use of lib
and self
#2332
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
helpers
in internal useageself
lib
While I like the idea of having
lib.nixvim
access internally within our lib, keeping our lib (self
) separate from the extended lib will be better in the long-term.This is intended to simplify accessing a lib overlay without needing to first evaluate parts of our custom lib (#2328).
it isn't really part of our (lib/types.nix
is a bit of a special case,lib.nixvim
scoped) custom lib. Instead it is part of the lib extension overlay. Therefore we can use either strategy of passing it{ lib = final; }
or{ lib = prev; inherit self; }
. Feedback is welcome on which approach is preferred.EDIT: the above paragraph isn't true anymore. To avoid awkward bootstrapping we now (once again) build our types internally, as
lib.nixvim.types
. This is still merged intolib.types
in the overlay though.