Merged
Conversation
Contributor
- Use #[non_exhaustive] instead of __LAST sentinel variant - Fix mutable borrow conflict in tokenizer by pattern matching on &Context - Remove redundant .clone() calls in path_util and str_util The __LAST variant was added in 2019 as a workaround before #[non_exhaustive] was stabilized (Rust 1.40, December 2019). Now that it's been stable for 6+ years, we can use the proper attribute.
- actions/checkout v3 -> v4 - actions-rs/toolchain v1 -> dtolnay/rust-toolchain@stable (actions-rs is unmaintained) - Swatinem/rust-cache v2.0.0 -> v2 - actions-rs/cargo v1 -> direct cargo commands (actions-rs is unmaintained)
philiptaron
approved these changes
Jan 28, 2026
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
There's a breaking change in here, but it's due to mid-2019 Rust not having [[nonexhaustive]]. Let's roll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I fixed the warnings Clippy showed. Mostly because Clippy helps me improve my code, and having warnings is distracting.
I'm also trying to add a CI step to run Clippy checks.