Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial ci #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial ci #16

wants to merge 1 commit into from

Conversation

Rizary
Copy link
Collaborator

@Rizary Rizary commented Dec 17, 2020

Progress tracking for adding ci to todomvc-nix.

@Rizary Rizary requested a review from zimbatm December 17, 2020 07:22
@Rizary
Copy link
Collaborator Author

Rizary commented Dec 17, 2020

this works by running nix-build nix/release.nix but what about nix build?

@zimbatm
Copy link
Member

zimbatm commented Apr 29, 2021

This is sorely needed. The repo needs a github action CI

@peterbecich
Copy link
Collaborator

The GitHub Action is completed now. It checks the nix develop shell and nix flake check. There is no target for nix build so it does not check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbecich peterbecich peterbecich approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees

@Rizary Rizary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rizary @zimbatm @peterbecich