Use from_bits_retain for all Termios wrapper fields. #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there are any unrecognised bits, they should be kept when setting fields of the underlying libc termios struct in get_libc_termios, rather than being dropped. This ensures that termios can be roundtripped even with unrecognised bits set.
asomers
reviewed
Dec 8, 2023
I think so, can you test it? |
No, I can't. I don't have an Illumos system. Maybe @nospam3089 can test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
In case there are any unrecognised bits, they should be kept when setting fields of the underlying libc
termiosstruct inget_libc_termios, rather than being dropped. This ensures that termios can be roundtripped even with unrecognised bits set.(I came across this issue on Android in part of the NFC stack, but it should also fix #2071.)
Checklist:
CONTRIBUTING.md