test(button): attributes #692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
petergoes
force-pushed
the
test--add-button-attribute-tests
branch
from
a38d28a to
d3e4414
Compare
petergoes
force-pushed
the
test--add-button-attribute-tests
branch
from
d3e4414 to
ca0342d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 24 +2
Lines 240 284 +44
Branches 39 50 +11
=========================================
+ Hits 240 284 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richadr
reviewed
Nov 10, 2025
Contributor
richadr
left a comment
richadr
left a comment
There was a problem hiding this comment.
kan wat mij betreft gemerged worden. maar ik vind checken dat de props worden doorgezet als attribute op het button-element nuttiger dan de todo's.
packages/components-react/button-react/src/button-attributes.test.tsx
Outdated
Show resolved
Hide resolved
packages/components-react/button-react/src/button-attributes.test.tsx
Outdated
Show resolved
Hide resolved
petergoes
force-pushed
the
test--add-button-attribute-tests
branch
from
ca0342d to
372802c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.