chore(link-react): depricate aria-current en aria-disabled #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## docs--improve-link-stories #762 +/- ##
============================================================
Coverage 100.00% 100.00%
============================================================
Files 26 26
Lines 296 296
Branches 51 51
============================================================
Hits 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It allows us to deep merge objects in the meta object
petergoes
force-pushed
the
docs--improve-link-stories
branch
from
ce62bc1 to
2d40c4a
Compare
petergoes
force-pushed
the
docs--link-props-without-some-aria-attrs
branch
from
0cfb2c4 to
7c58e65
Compare
The `disabled` and `current` props should be used instead
petergoes
force-pushed
the
docs--improve-link-stories
branch
from
2d40c4a to
55ed3d5
Compare
petergoes
force-pushed
the
docs--link-props-without-some-aria-attrs
branch
from
7c58e65 to
e4eeb50
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deze PR depricate de
aria-currentenaria-disabledattributen in de Link component omdat decurrentendisabledprops deze attributen zetten, maar ook meer doen. Die props zijn dus gewenst over de aria varianten