Cookie consent #245
Cookie consent #245
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
===========================================
- Coverage 100.00% 94.27% -5.73%
===========================================
Files 12 43 +31
Lines 694 1188 +494
Branches 100 244 +144
===========================================
+ Hits 694 1120 +426
- Misses 0 61 +61
- Partials 0 7 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Load saved preferences from localStorage and set radio buttons accordingly | ||
| // This works with preferences saved from the cookie banner or from a previous visit to this page | ||
| try { | ||
| const saved = globalThis.localStorage?.getItem(STORAGE_KEY); |
There was a problem hiding this comment.
Zit er nog een maximumtijd aan hoe lang we cookies mogen bewaren? Moet daarover ook iets vermeld worden?
There was a problem hiding this comment.
Vergelijkbaar: nu kun je consent alleen setten met JS, ik las verderop iets over prgressive enhancement. Moet er mss een aanbeveling sijn om dit met forms + server-side cookies te doen zodat ook server-side de consent preferences kunnen worden uitgelezen?
ermenm
force-pushed
the
feature/cookie-consent
branch
from
2e4b12e to
881ff05
Compare
ermenm
force-pushed
the
feature/cookie-consent
branch
from
881ff05 to
50d51be
Compare
ermenm
force-pushed
the
feature/cookie-consent
branch
from
d2b4ab8 to
0479279
Compare
|
This is a demo implementation, therefore localStorage has been used to set "cookies"/"preferences".
To view the cookie banner in action on a page, visit this link:
Mijn omgeving
To clear your cookies, clear your localStorage in your browser.