Skip to content

Conversation

@jurgenbelien
Copy link
Contributor

@jurgenbelien jurgenbelien commented Oct 16, 2025

An example how we could work with css files directly in lit. There are some drawbacks to this though:

  • Currently, packages/theme-wizard-website is responsible to build downstream packages/lit, because the latter exposes the source index.ts as its package entrypoint. This would mean that any vite plugins/settings to make packages/lit build would have to be included in theme-wizard-website as well. This would leak complexity of the build of packages/lit to the packages/theme-wizard-website. This PR changes it to the built version of packages/lit.
  • Aforementioned results in a cascading dependency: packages/theme-wizard-website and packages/theme-wizard-storybook can only be built when packages/lit successfully built.
  • The inner workings of the vite-plugin-lit-css break hot module reloading for css files specifically. To see your css changes, you would need to trigger a reload.

Changes

  • Add vite-plugin-lit-css to directly import css files
  • Add index.html to demo lit web components in packages/lit
  • Expose build artifact of packages/lit as main export.
  • Show css import in one component

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
theme-wizard Error Error Oct 16, 2025 0:09am
theme-wizard-server Error Error Oct 16, 2025 0:09am
theme-wizard-storybook Error Error Oct 16, 2025 0:09am

@sonarqubecloud
Copy link

@bartveneman
Copy link
Contributor

Kunnen we deze sluiten?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants