Skip to content

Commit

Permalink
chore: align @types/node with node version
Browse files Browse the repository at this point in the history
Align @types/node with the version of node that is used in the repo. Add
a comment to update @types/node when the node version in the repo is
bumped.

Prevent npm-check-updates and Dependabot from bumping @types/node major
versions.
  • Loading branch information
matijs committed Oct 29, 2024
1 parent 46376aa commit a30f933
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 5 deletions.
15 changes: 13 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,19 @@ updates:
directory: "/"
schedule:
interval: "monthly"
versioning-strategy: "increase-if-necessary"
groups:
patch-and-minor-dependencies:
applies-to: "version-updates"
update-types:
- "patch"
- "minor"
ignore:
# Color package uses ES6 syntax from v4+ which is not compatible with our setup
- dependency-name: "color"
update-types: ["version-update:semver-major"]
update-types:
- "version-update:semver-major"
# Keep @types/node in line with the version of node in the repository
- dependency-name: "@types/node"
update-types:
- "version-update:semver-major"
versioning-strategy: "increase-if-necessary"
2 changes: 2 additions & 0 deletions .ncurc.major.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ module.exports = {
...minorConfig,
reject: [
...minorConfig.reject,
// @types/node is kept in line with the node version in .nvmrc and package.json#engines.node
'@types/node',
'color',
'@fontsource/*',
// Prettier 3 is async
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@gemeente-denhaag/process-steps": "0.1.0-alpha.230",
"@gemeente-denhaag/step-marker": "0.0.1-alpha.102",
"@nl-design-system/component-index": "1.0.0-alpha.30",
"@types/node": "22.1.0",
"@types/node": "20.14.14",
"@typescript-eslint/eslint-plugin": "8.0.0",
"@typescript-eslint/parser": "8.0.0",
"@utrecht/component-library-css": "4.2.0",
Expand Down
4 changes: 2 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a30f933

Please sign in to comment.