Skip to content

Conversation

@Rozerinay
Copy link
Contributor

@Rozerinay Rozerinay commented Dec 11, 2025

nl-design-system/documentatie#2809

In deze PR heb ik de kleurwaarden van alle common kleur-tokens opnieuw ingevuld, met uitzondering van de dataset-kleuren.

Daarnaast zijn ook alle dark-mode kleurwaarden bijgewerkt. Het gaat om tientallen tokenwijzigingen, daarom is er geen volledige opsomming per token opgenomen.

Toelichting

  • Alle waarden zijn opnieuw gegenereerd en afgestemd via Accessible Palette.
  • Dataset-kleuren zijn bewust niet meegenomen; deze worden later herzien omdat ze nog afhankelijk zijn van de brand-laag.
  • De brand-laag zelf is in deze PR nog niet verwijderd om regressies te voorkomen.

@Rozerinay Rozerinay requested a review from a team as a code owner December 11, 2025 12:39
@vercel
Copy link

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
themes Ready Ready Preview Comment Dec 12, 2025 1:40pm

@Rozerinay Rozerinay added the do not merge Pull requests that should not be merged just yet label Dec 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (a080b79) to head (0fbd5aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          19       19           
  Lines        1392     1392           
  Branches      170      170           
=======================================
  Hits         1246     1246           
  Misses        145      145           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richadr richadr force-pushed the style/change-ma-color-tokens branch from 47aa6e0 to 0fbd5aa Compare December 12, 2025 13:36
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Pull requests that should not be merged just yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants