Skip to content

Conversation

@eslook
Copy link
Contributor

@eslook eslook commented Dec 23, 2025

No description provided.

@eslook eslook requested review from a team as code owners December 23, 2025 15:25
@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
themes Ready Ready Preview, Comment Dec 23, 2025 4:21pm

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (66d96f0) to head (34faf96).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          19       19           
  Lines        1392     1392           
  Branches      185      128   -57     
=======================================
  Hits         1246     1246           
- Misses        145      146    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Robbert Robbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit!

Het voornaamste dat nog mist is een dependency op de webfonts van IBM Plex.

Je hoeft ze misschien nog niet per se aan de npm package toe te voegen, maar het is wel nodig dat ze ingeladen worden bij de stories.

Je kunt bij andere design token packages zien hoe dat wordt aangepakt met een font.js en die opnemen in preview.ts van Storybook

@eslook eslook requested a review from Robbert December 23, 2025 16:17
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
57.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants