Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add utrecht pagination tokens #756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rozerinay
Copy link
Contributor

@Rozerinay Rozerinay commented Oct 21, 2024

Didn't use the following tokens because they are not supported in Figma:

  • utrecht.pagination.margin-block-end
  • utrecht.pagination.margin-block-start
  • utrecht.pagination.distanced.margin-inline-start
  • utrecht.pagination.relative-link.distanced.margin-inline-end
  • utrecht.pagination.relative-link.distanced.margin-inline-start

I also used the following todo tokens in the component in Figma, but they already existed:

  • todo.pagination.line-height
  • todo.pagination.relative-link.active.background-color
  • todo.pagination.relative-link.active.border-color
  • todo.pagination.relative-link.active.color
  • todo.pagination.relative-link.focus.background-color
  • todo.pagination.relative-link.focus.color
  • todo.pagination.page-link.active.background-color
  • todo.pagination.page-link.active.border-color
  • todo.pagination.page-link.active.color
  • todo.pagination.page-link.focus.background-color
  • todo.pagination.page-link.focus.color

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 1:25pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (69400a5) to head (8ace9af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          13       13           
  Lines        1049     1049           
  Branches      147      147           
=======================================
  Hits          938      938           
  Misses        110      110           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rozerinay Rozerinay marked this pull request as ready for review October 24, 2024 07:40
@Rozerinay Rozerinay requested a review from a team as a code owner October 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants