Skip to content

feat: theme builder v2 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Robbert wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

feat: theme builder v2 #925

Robbert wants to merge 46 commits into from

Conversation

@Robbert
Copy link
Member

@Robbert Robbert commented Jan 17, 2025 •
edited
Loading

  • Fix regressions in Purmerend theme that are not caught by Chromatic because screenshots for Purmerend are temporarily disabled

Marwa and others added 24 commits November 1, 2024 11:03
@Robbert
feat: add project-wallace-purmerend-tokens
0bdd1d6
@Robbert
feat: create ColorPickerCombobox
717b3e7
@Robbert
feat: add colorpickercombobox lables
7b09eea
@Robbert
add fontfamily picker
a156701
@Robbert
feat: add combobox
2beea1b
@Robbert
chore: fix things after rebasing
26ded2f
@Robbert
refactor: basis theme improvements
a17ed4d
@Robbert
feat: add radix colors to basis theme
4c6ee3d
@Robbert
refactor: use common color scales in basis-theme
876f066
@Robbert
refactor: use basis token for font-weight
062dd93
@Robbert
refactor: create token for transparent color
83f2c76
@Robbert
refactor: add basis.heading.* tokens
4ab1a00
@Robbert
refactor: add basis.pointer-target.* tokens
44b7996
@Robbert
docs: include token reference in tokens table
a29ce6a
@Robbert
refactor: use more basis.* tokens
4110346
@Robbert
refactor: basis.form-control instead of utrecht.form-control, and…
e112638 
… remove old gray color scale
@Robbert
chore: add generateRadixColors from Radix website
20801d3 
https://github.com/radix-ui/website/blob/11f0607c5130fb3b5d082962fdc17d1846511c47/components/generateRadixColors.tsx
@Robbert
refactor: migrate more tokens from purmerend to basis-theme
94bf653
@Robbert
docs: fix missing labels in component stories
9ee764b
@Robbert
docs: add component tokens page to basis theme
a8c8b0b
@Robbert
wip: radix color generator
8d7be83
@Robbert
feat: add mark-inverse and selected-inverse color scales to Purmerend
c2dab25
@Robbert
feat: add theme builder page
b939e7f
@Robbert
chore: limit width of text content to approx 70 chars
062e176
@Robbert Robbert requested a review from a team as a code owner January 17, 2025 13:21
@vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:48am

@Robbert Robbert force-pushed the feat/theme-builder-v2 branch from fec3652 to c90ef87 Compare March 24, 2025 11:19
@Robbert Robbert marked this pull request as draft March 24, 2025 11:31
auto-merge was automatically disabled March 24, 2025 11:31

Pull request was converted to draft

@Robbert Robbert force-pushed the feat/theme-builder-v2 branch from d78c5c7 to 84fbb18 Compare March 28, 2025 15:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartveneman bartveneman bartveneman left review comments

@jeffreylauwers jeffreylauwers Awaiting requested review from jeffreylauwers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Robbert @bartveneman @Yolijn @jeffreylauwers