Skip to content

Conversation

@FinnWard
Copy link

narrowed type prop for Alert as any unknown types were changed to "info"
updated role prop to still accept any string but the autocomplete suggestions will now show the AlertRoles enum

before:
image

now:
image

@vercel
Copy link

vercel bot commented Aug 27, 2025

Someone is attempting to deploy a commit to the nl-design-system Team on Vercel.

A member of the Team first needs to authorize it.

@FinnWard FinnWard changed the title Alert fix Alert prop types improvement Aug 27, 2025
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (f74ab20) to head (0fb98cc).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   90.62%   90.98%   +0.35%     
==========================================
  Files         196      200       +4     
  Lines        1739     1752      +13     
  Branches      384      381       -3     
==========================================
+ Hits         1576     1594      +18     
+ Misses        157      154       -3     
+ Partials        6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FinnWard FinnWard changed the title Alert prop types improvement Fix: Alert prop types improvement Aug 27, 2025
@FinnWard
Copy link
Author

Voor de sonarqube issue, de 'a' | 'b' | ({} & string) type zorgt ervoor dat de union niet resolved word en de verschillende voorgestelde strings in de type suggestion blijft maar tegelijkertijd staat dit ook toe als je een string invoert die niet in de union zit.

@Robbert
Copy link
Member

Robbert commented Aug 27, 2025

thanks! ga ik even over nadenken nog

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants