Skip to content

Conversation

@ermenm
Copy link

@ermenm ermenm commented Dec 17, 2025

  • NavBar: render a semantic <nav> instead of <div>, add a label prop that maps to aria-label.
  • NavList:
    • add an inline prop for non–full‑width lists;
    • support a current prop combined with aria-current on NavListLink and NavListLinkButton.
  • CSS: introduce .utrecht-nav-list__link--current with a stronger visual current state (font weight, optional background via design tokens).
  • Storybook: add examples for multiple navigation lists, a navigation list with an action group, a navigation list with a search widget, and a navigation list with a current item.

This improves semantics and accessibility (following WCAG G128 and WAI Wiki <nav>) and makes it easier to compose realistic navigation bars.

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
utrecht Ready Ready Preview, Comment Dec 18, 2025 11:20am

@Robbert
Copy link
Member

Robbert commented Dec 17, 2025

De PR was eerst via een fork gemaakt, daar had ik al een review achtergelaten: #3001 (review)

@Robbert Robbert requested review from Robbert and bddjong December 17, 2025 16:06
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (5449e7b) to head (79d225c).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
+ Coverage   90.73%   90.83%   +0.09%     
==========================================
  Files         201      201              
  Lines        1760     1768       +8     
  Branches      383      385       +2     
==========================================
+ Hits         1597     1606       +9     
+ Misses        157      156       -1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants