Implement IFormattable on Option<T> #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renders Option<T>.ToString() consistent with Nullable<T>.ToString() and easier to substitute for.
Instead of hopping over another String.Format (and causing an allocation of another format string), delegate to the underlying implementation of IFormattable on the value if it exists, otherwise to Option's own ToString().
atifaziz
force-pushed
the
formattable
branch
from
03f6c03
to
c2f0318
Compare
|
@nlkl Is there a reason this is not merged? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #19 and addresses #20 to fully address the examples called out in #17.
The
IFormattableimplementation is explicit.