Fix for printing long doubles bug in dump_float #3929
Conversation
When you use long double as a floating point type with the current version of this file and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string.
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
nlohmann
left a comment
nlohmann
left a comment
There was a problem hiding this comment.
The library targets C++11. Please adjust the code.
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
|
I think a test is missing or? |
|
Yes, a test is definitely required. There is also #3906 that I need to take care of to finally have a green CI again. I'm busy right now, so sorry for delays. |
|
Please update to recent develop version - the CI is fixed there (see #3906). |
|
@nlohmann, it asks for your approval to run CI workflows. |
|
@nlohmann, @gregmarr, what's wrong with Cirrus CI / check? |
Looks like a glitch. |
|
Any update on this? Tests are still missing. |
|
Please update to the latest develop branch and add a test. |
|
@RUSLoker It would be great if you could add a test so we can merge this. |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
github-actions
bot
added
the
state: stale
5 participants
When you use long double as a floating point type with the current version of include/nlohmann/detail/output/serializer.hpp and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string.