-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Ordered map remove duplicate codes #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Ordered map remove duplicate codes #4057
Conversation
… that were missing: 1. iota 2. copy 3. copy if 4. copy n
make amalgamat
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @Tomerkm |
nlohmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amalagamate the source code.
|
(Also, please update from the develop branch as it has a working CI now.) |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
I removed the code at the function:
std::pair<iterator, bool> emplace(const key_type& key, T&& t)
and replaced which a method that exists at the class and do the job.
The method find do the same as the iterate at the code does.
Instead of writing the same code, I have called the method find.
The idea is to use the function does the job instead of rewriting the same code.
I want to see if this ok before I change on the others.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.Please don't
#ifdefs or other means.