Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include button to edit tags #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include button to edit tags #27

wants to merge 1 commit into from

Conversation

Merovius
Copy link
Contributor

@Merovius Merovius commented Jul 9, 2015

Preview:
Preview

@koebi
Copy link
Contributor

koebi commented Jul 9, 2015

Up to now, this button does nothing, right? As do all buttons? (Not sure about the last). I would rather merge this, if the button is added some functionality…

@Merovius
Copy link
Contributor Author

My proposal is:
a) The backend gets a POST handler /change_description, that takes a JSON-document, containing the keys "uuid" and "description". The return code is 200 in case of success or an appropriate error otherwise. A JSON document is returned, which contains the key "error" with a more detailed description, if any and the key "new_description", when no error occured. This can be implemented by anyone who can write go (koebi or me, probably)
b) The frontend, on click on the edit-button, changes the description field of the respective card to a textfield. When enter is pressed, the new card description is send via Ajax to the handler from a) with an appropriate loading animation. Once the handler returns, the textfield changes back to the label, with the new description. This can be implemented by anyone.

@Merovius
Copy link
Contributor Author

The material design spec gives some guideluines about how the inline editing should be done. I'd suggest ("Placeholder text" OR "Small edit dialog") AND "inline edit icon".

@koebi
Copy link
Contributor

koebi commented Dec 28, 2015

Not quite sure on the frontend, but why don't we just use a form as we do on the login page?

@koebi
Copy link
Contributor

koebi commented Jan 3, 2016

Unfortunately, Dialogs are not yet included in mdl…

@koebi
Copy link
Contributor

koebi commented Feb 10, 2016

As of version 1.1, material design has dialogs. It might be worth taking a look at that…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants