Skip to content

Skip connection request #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Skip connection request #241

merged 1 commit into from
Apr 1, 2025

Conversation

@gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented Mar 13, 2025

For TCP or MQTT, let pub node skip the connection request.

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [*]Passed [ ]Failed [ ]Skipped

@gichan-jang
Skip connection request
4b0b09d 
For TCP or MQTT, let pub node skip the connection request.

Signed-off-by: Gichan Jang <[email protected]>
@myungjoo
Copy link
Member

myungjoo commented Mar 26, 2025

Tested in real connection setting?

songgot
songgot approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean Code !!, LGTM!!

@jaeyun-jung jaeyun-jung merged commit 4cb64d3 into nnstreamer:main Apr 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myungjoo myungjoo myungjoo approved these changes

@songgot songgot songgot approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gichan-jang @myungjoo @songgot @jaeyun-jung