std::tread and joint to remove threads to load #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jijoongmoon
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
jijoongmoon
changed the title
jijoongmoon
changed the title
jijoongmoon
force-pushed
the
threads
branch
2 times, most recently
from
6ee506d to
4487b95
Compare
DonghakPark
reviewed
Dec 3, 2025
nntrainer/models/neuralnet.cpp
Outdated
|
|
||
| for (auto &f : futures) | ||
| f.get(); | ||
| for (auto &t : threads) |
Member
There was a problem hiding this comment.
for (auto& t : threads) {
if (t.joinable()) {
t.join();
}
}For avoid std::system_error, how about add check joinable() before join
This PR fixes load function using std::thread rather than futures. For windows, the threads created by futures are not removed and the total number of threads are increase. We fixes this by using std::thread and join. Signed-off-by: jijoong.moon <[email protected]>
songgot
reviewed
Dec 3, 2025
songgot
reviewed
Dec 3, 2025
| } else { | ||
| #if defined(_WIN32) | ||
| // Map per-task, then unmap immediately after: enables early release | ||
| // Map per-ask, then unmap immediately after: enables early release |
Contributor
There was a problem hiding this comment.
Maybe typo? 'per-ask' -> 'per-task'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency of the PR
This PR fixes load function using std::thread rather than futures.
For windows, the threads created by futures are not removed and the
total number of threads are increase.
We fixes this by using std::thread and join.
signed-off-by jijoong.moon[email protected]