Skip to content

Fix Windows Build Warnings #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows Build Warnings #3603

wants to merge 1 commit into from
+269 −208

Conversation

@djeong20
Copy link
Contributor

@djeong20 djeong20 commented Dec 4, 2025 •
edited
Loading

Summary of Code Fixes:

  1. Type Conversion Warnings (C4244, C4267, C4146, C4293):

    • Fixed across 19 files (layers, optimizers, dataset handlers, tensor operations).
    • Added explicit type casts (e.g., static_cast<unsigned int>).
    • Used literal suffixes for precision (e.g., 1.0f instead of 1.0).

  2. MSVC Compiler Flag Warnings (D9024, D9025, D9027):

    • Removed manual /MT and /MD flags from MSVC configuration.
    • Resolved runtime library conflicts with subprojects (CLBlast, iniparser).

  3. Hexadecimal Floating-Point Warnings (C4305, C4309):

    • Fixed in avx2_impl.cpp by adding f suffix to literals (e.g., 0x1.c6af84b912394p-5f).
    • Ensured single-precision float type instead of double.

DonghakPark
DonghakPark approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!!

@djeong20 djeong20 force-pushed the fix/windows/build_warning branch 4 times, most recently from 5a55572 to 3a63ba8 Compare December 4, 2025 08:39
@djeong20 djeong20 linked an issue Dec 4, 2025 that may be closed by this pull request
Windows Build Warning #3581
Open
@djeong20 djeong20 force-pushed the fix/windows/build_warning branch 3 times, most recently from e4665e9 to d36bf92 Compare December 4, 2025 11:11
@djeong20
Fix Windows Build Warnings
f903605 
This PR resolves Windows build warnings.

- Type Conversion Warnings (C4244, C4267, C4146, C4293)
- MSVC Compiler Flag Warnings (D9024, D9025, D9027)
- Hexadecimal Floating-Point Warnings (C4305, C4309)

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@djeong20 djeong20 force-pushed the fix/windows/build_warning branch from d36bf92 to f903605 Compare December 4, 2025 11:39
songgot
songgot approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songgot songgot songgot approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Need Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows Build Warning

3 participants

@djeong20 @songgot @DonghakPark