Meson: Force _ITERATOR_DEBUG_LEVEL=2 for Meson debug builds on Windows #3607
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses known Meson limitations in applying b_vscrt settings for clang++.exe in C++ builds. This ensures debug behavior matches Visual Studio Debug configurations when using buildtype=debug. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
myungjoo
approved these changes
Dec 5, 2025
songgot
reviewed
Dec 5, 2025
| # Just setting buildtype=debug may not switch the CRT or iterator level. | ||
| # Therefore, forcing _ITERATOR_DEBUG_LEVEL=2 for Meson debug build to match VS Debug | ||
| if build_machine.system() == 'windows' | ||
| add_project_arguments('-D_ITERATOR_DEBUG_LEVEL=2', language : 'cpp') |
Contributor
There was a problem hiding this comment.
:)
Suggested change
| add_project_arguments('-D_ITERATOR_DEBUG_LEVEL=2', language : 'cpp') | |
| add_project_arguments('-D_ITERATOR_DEBUG_LEVEL=2', language: 'cpp') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses known Meson limitations in applying b_vscrt settings for clang++.exe in C++ builds.
This ensures debug behavior matches Visual Studio Debug configurations when using buildtype=debug.
Self-evaluation: