Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and reformat vicuna script #1697

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix and reformat vicuna script #1697

merged 1 commit into from
Jul 27, 2023

Conversation

jinchen62
Copy link
Contributor

@jinchen62 jinchen62 commented Jul 27, 2023 •
edited
Loading

and some cleanup

@jinchen62 jinchen62 force-pushed the fix_vicuna branch 2 times, most recently from 341ecaf to 4a137b6 Compare July 27, 2023 08:28
@jinchen62 jinchen62 changed the title Fix vicuna script Fix and reformat vicuna script Jul 27, 2023
dan-garvey
dan-garvey previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dan-garvey dan-garvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved assuming you tested the configurations

@dan-garvey dan-garvey self-requested a review July 27, 2023 22:24
@dan-garvey dan-garvey merged commit 4d5c55d into nod-ai:main Jul 27, 2023
2 of 6 checks passed
@jinchen62 jinchen62 deleted the fix_vicuna branch July 27, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-garvey dan-garvey dan-garvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchen62 @dan-garvey