Skip to content

Bump IREE to iree-org/iree@402a9be46a #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Abhishek-Varma
Copy link
Contributor

-- This commit bumps IREE to iree-org/iree@402a9be46a. -- As part of the same it :-
a. removes "dangling" builders
b. adds explicit cast
c. adds explicit result type of enum

Signed-off-by: Abhishek Varma [email protected]

-- This commit bumps IREE to iree-org/iree@402a9be46a.
-- As part of the same it :-
   a. [removes "dangling" builders](iree-org/iree#21364)
   b. [adds explicit cast](iree-org/iree#21494)
   c. [adds explicit result type of enum](llvm/llvm-project#150308)

Signed-off-by: Abhishek Varma <[email protected]>
@Abhishek-Varma
Copy link
Contributor Author

For build to succeed mlir-air needs to be updated.

Locally I have tried the following patch and the build succeeded :-

diff --git a/mlir/lib/Conversion/AIRLoweringPass.cpp b/mlir/lib/Conversion/AIRLoweringPass.cpp
index 3922980..b3d5ae6 100644
--- a/mlir/lib/Conversion/AIRLoweringPass.cpp
+++ b/mlir/lib/Conversion/AIRLoweringPass.cpp
@@ -1182,7 +1182,11 @@ public:
       // Label root of perfectly nested affine for loops for affine
       // optimizations.
       std::vector<SmallVector<mlir::affine::AffineForOp, 6>> bands;
-      mlir::affine::getTileableBands(f, &bands);
+      for (mlir::affine::AffineForOp forOp : f.getOps<mlir::affine::AffineForOp>()) {
+        SmallVector<mlir::affine::AffineForOp, 6> band;
+        getPerfectlyNestedLoops(band, forOp);
+        bands.push_back(band);
+      }
       for (auto &band : bands) {
         band[0]->setAttr("affine_opt_label",
                          StringAttr::get(f.getContext(), "tiling"));

CC: @erwei-xilinx could you please take a look ? I tried raising a PR for mlir-air but the bump seemed involved hence sharing the patch above which worked locally.

@erwei-xilinx
Copy link
Contributor

erwei-xilinx commented Jul 30, 2025

CC: @erwei-xilinx could you please take a look ? I tried raising a PR for mlir-air but the bump seemed involved hence sharing the patch above which worked locally.

Sure, let me take a look.

@erwei-xilinx
Copy link
Contributor

@Abhishek-Varma mlir-air has updated its llvm version: Xilinx/mlir-air#1056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants