Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak tag create from buffer #12

Open
wants to merge 38 commits into
base: libgit-next
Choose a base branch
from

Conversation

julianmesa-gitkraken
Copy link

If the tag already exists and we are not forcing overwrite we need to free ref_name buffer before return the "tag already exists" error.

implausible and others added 30 commits January 26, 2022 14:36
GitHub is removing support for the unauthenticated git protocol; test
with the https protocol.
Provide individual file ownership checks for both the current user and
the system user, as well as a combined current user and system user
check.
Ensure that the repository directory is owned by the current user; this
prevents us from opening configuration files that may have been created
by an attacker.
Provide a mock for file ownership for testability.
Test that we prevent opening directories that are not owned by
ourselves.
Pull the global configuration loader out of the symlink check so that it
can be re-used.
Obey the `safe.directory` configuration variable if it is set in the
global or system configuration. (Do not try to load this from the
repository configuration - to avoid malicious repositories that then
mark themselves as safe.)
Introduce the `GIT_OPT_SET_OWNER_VALIDATION` option, so that users can
disable repository ownership validation.
Validate repository directory ownership (v1.3)
It is a string array of the filters you want to disable in checkout
…s-on-no-nanoseconds-repos

Fix degraded performance using GIT_USE_NSEC on repos cloned with GIT_USE_NSEC disabled
There is a typo, Instead comparing nanoseconds to zero the code is comparing seconds to zero
we want to build a partial stash from an index in the future, so some functions have been reworked to allow for this
gitkraken-jacobw and others added 8 commits July 14, 2022 10:18
code has been moved from `git_stash_save` into `git_stash_save_with_opts` in order to handle cases where we want to partially stash using options or stash normally without partially stashed paths specified
If the tag already exists and we are not forcing overwrite we need to free ref_name buffer before return the "tag already exists" error.
@julianmesa-gitkraken julianmesa-gitkraken changed the base branch from master to libgit-next November 3, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants