forked from libgit2/libgit2
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leak tag create from buffer #12
Open
julianmesa-gitkraken
wants to merge
38
commits into
nodegit:libgit-next
Choose a base branch
from
julianmesa-gitkraken:fix-leak-tag_create_from_buffer
base: libgit-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix leak tag create from buffer #12
julianmesa-gitkraken
wants to merge
38
commits into
nodegit:libgit-next
from
julianmesa-gitkraken:fix-leak-tag_create_from_buffer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub is removing support for the unauthenticated git protocol; test with the https protocol.
Provide individual file ownership checks for both the current user and the system user, as well as a combined current user and system user check.
Ensure that the repository directory is owned by the current user; this prevents us from opening configuration files that may have been created by an attacker.
Provide a mock for file ownership for testability.
Test that we prevent opening directories that are not owned by ourselves.
Pull the global configuration loader out of the symlink check so that it can be re-used.
Obey the `safe.directory` configuration variable if it is set in the global or system configuration. (Do not try to load this from the repository configuration - to avoid malicious repositories that then mark themselves as safe.)
Introduce the `GIT_OPT_SET_OWNER_VALIDATION` option, so that users can disable repository ownership validation.
Validate repository directory ownership (v1.3)
v1.3.1 release
…library' into libgit-next
…new' into libgit-next
It is a string array of the filters you want to disable in checkout
…USE_NSEC disabled
…s-on-no-nanoseconds-repos Fix degraded performance using GIT_USE_NSEC on repos cloned with GIT_USE_NSEC disabled
There is a typo, Instead comparing nanoseconds to zero the code is comparing seconds to zero
Fix the GIT_USE_NSEC performance fix
we want to build a partial stash from an index in the future, so some functions have been reworked to allow for this
code has been moved from `git_stash_save` into `git_stash_save_with_opts` in order to handle cases where we want to partially stash using options or stash normally without partially stashed paths specified
stash: partial stash specific files
If the tag already exists and we are not forcing overwrite we need to free ref_name buffer before return the "tag already exists" error.
ianhattendorf
force-pushed
the
libgit-next
branch
from
February 14, 2024 20:58
0ac7af7
to
efdaa4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tag already exists and we are not forcing overwrite we need to free ref_name buffer before return the "tag already exists" error.