Skip to content

lookup: add openid-client #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

lookup: add openid-client #1072

wants to merge 4 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Oct 15, 2024

adds openid-client (and intrinsically also oauth4webapi and oidc-provider)

This covers the Web Cryptography API and Fetch API modules.

@panva
Copy link
Member Author

panva commented Oct 15, 2024

Hard Requirements

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only commands
  • The tests pass on supported major release lines (skipped <20 due to lack of webcrypto global)
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

  • The module must be actively used by the community
  • The module must be heavily depended on
  • The module must cover unique portions of our API (WebCryptoAPI, fetch API)
  • ❓ The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • The module is under the Node.js foundation Github org
  • The module is identified as an important module by a Node.js Working Group
    Procedure

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (92761dd) to head (e50ffb9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          29       29           
  Lines        2197     2197           
=======================================
  Hits         2038     2038           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panva panva force-pushed the add-openid-client branch from e50ffb9 to 4d35d31 Compare October 15, 2024 22:38
@richardlau

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva
Copy link
Member Author

panva commented Jun 21, 2025

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants