lib: reduce the length of the temporary directory path #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
reduce/path-length
branch
from
38b1423 to
5474978
Compare
lpinca
force-pushed
the
reduce/path-length
branch
from
5474978 to
ff28a5f
Compare
lpinca
changed the title
targos
approved these changes
Feb 20, 2025
jasnell
approved these changes
Feb 20, 2025
|
Here's a small test run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1708/ |
|
I deleted the branch, new run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1709/ |
|
It looks good, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#57005 (comment)
Checklist
npm testpasseshere