Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update tested Node.js versions #906

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

targos
Copy link
Member

@targos targos commented May 9, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #906 (40947b0) into main (153d6dd) will increase coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   95.15%   96.45%   +1.30%     
==========================================
  Files          28       28              
  Lines        2145     2145              
==========================================
+ Hits         2041     2069      +28     
+ Misses        104       76      -28     
Impacted Files Coverage Δ
lib/bin/citgm-all.js 95.37% <0.00%> (+0.84%) ⬆️
lib/bin/citgm.js 100.00% <0.00%> (+1.80%) ⬆️
lib/match-conditions.js 94.00% <0.00%> (+4.00%) ⬆️
lib/spawn.js 100.00% <0.00%> (+76.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153d6dd...40947b0. Read the comment docs.

@Trott
Copy link
Member

Trott commented May 9, 2022

Should we consider using https://github.com/pkgjs/action/blob/main/docs/USAGE.md to automatically update the test matrix as new versions are released and old versions go EOL? It's not immediately obvious from the docs, but it defaults to currently-supported Node.js versions.

@BethGriggs
Copy link
Member

Should we consider using https://github.com/pkgjs/action/blob/main/docs/USAGE.md to automatically update the test matrix as new versions are released and old versions go EOL? It's not immediately obvious from the docs, but it defaults to currently-supported Node.js versions.

Refs: #891

@targos targos merged commit 908ebe2 into nodejs:main May 9, 2022
@targos targos deleted the update-node branch May 9, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants