Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip static-import on v22 #80

Closed
wants to merge 1 commit into from
Closed

test: skip static-import on v22 #80

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

This test is making this module fail on v22 CITGM. This should give time to us to improve this test scenario for v23 >=.

Refs: nodejs/citgm#1060

@timfish
Copy link
Contributor

timfish commented May 24, 2024

Does this not just need fixing for v22?

@RafaelGSS
Copy link
Member Author

Does this not just need fixing for v22?

Possibly, yes. I just made this naive "solution" to unblock this module to run in the Node.js CITGM between releases.

@timfish timfish mentioned this pull request May 27, 2024
Merged
timfish
timfish requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@timfish timfish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests still fail with this PR because the imports for test/hook/v18-static-import-assert.mjs are evaluated before the version check.

#81 does the version evaluation before attempting to load the test file

@RafaelGSS RafaelGSS closed this May 27, 2024
bengl pushed a commit that referenced this pull request May 28, 2024
@timfish
test: skip static-import on > v21 (#81)
1e05e4b 
Better fix for #80

Closes #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish requested changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafaelGSS @timfish @anonrig