Fix encoding errors #554
Closed
Fix encoding errors #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when gyp reads and writes vcxproj files, it messes up with the encodings, because the generated XML files are stored as Latin-1 files instead of UTF-8.
It can become problematic since project files often contain paths, and paths can contain accented characters that are handled differently between Latin-1 and UTF-8. This PR addresses the issue by converting encoding to UTF-8 right before the file is saved.
This problem is not new, it has already been reported in issues #297, #404, #476 atom/atom#1937, AudioNet/node-core-audio#27, and many others. Pull request #366 was sent a year ago as an attempt to fix the problem, but wasn't taken into consideration. Two years after the initial report, this important issue remains unsolved.