Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: prefer symbol to number in webidl type function #55737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 5, 2024

It seems to be more suited.

@aduh95 aduh95 requested a review from jazelly November 5, 2024 23:09
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 5, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (e53fe03) to head (7403a7a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55737   +/-   ##
=======================================
  Coverage   88.39%   88.40%           
=======================================
  Files         654      654           
  Lines      187728   187729    +1     
  Branches    36117    36118    +1     
=======================================
+ Hits       165948   165956    +8     
+ Misses      15015    15007    -8     
- Partials     6765     6766    +1     
Files with missing lines Coverage Δ
lib/internal/webidl.js 93.18% <100.00%> (+0.01%) ⬆️

... and 16 files with indirect coverage changes

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants