Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure that test priority is not higher than current priority #55739

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Contributor

This test fails if parent's (e.g. sshd) niceness is already lower than 10 and we're not root.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2024
@LiviaMedeiros LiviaMedeiros added os Issues and PRs related to the os subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 6, 2024
@nodejs-github-bot

This comment was marked as outdated.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (1aa7135) to head (07bb919).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55739   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         654      654           
  Lines      187747   187747           
  Branches    36127    36123    -4     
=======================================
+ Hits       165972   165974    +2     
+ Misses      15009    15008    -1     
+ Partials     6766     6765    -1     

see 21 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants