Skip to content

test: file read no exist update to test runner #55751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Josef-Spiteri
Copy link

@Josef-Spiteri Josef-Spiteri commented Nov 6, 2024

Refactored the test-file-read-noexist.js to use test runner.

Test result:
image

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2024
@Josef-Spiteri Josef-Spiteri force-pushed the test-file-read-noexist-refactor branch from 7566a2c to b92df9e Compare November 6, 2024 16:06
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2024
@Josef-Spiteri Josef-Spiteri force-pushed the test-file-read-noexist-refactor branch from b92df9e to 9592f24 Compare November 6, 2024 16:18
@Josef-Spiteri Josef-Spiteri force-pushed the test-file-read-noexist-refactor branch from 9592f24 to e98a900 Compare November 6, 2024 16:19
@Josef-Spiteri
Copy link
Author

Hi @jasnell, when you have time would it be possible to trigger a CI testing run, please?

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants