test: use test runner in eventtarget-once-twice test #55752
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander “weej” Jones <[email protected]>
nodejs-github-bot
added
needs-ci
pmarchini
reviewed
Nov 6, 2024
| et.dispatchEvent(new Event('foo')); | ||
| })(); | ||
|
|
||
| }); |
pmarchini
added
the
code-and-learn
…ease the linter...
RedYetiDev
reviewed
Nov 6, 2024
| await once(et, 'foo'); | ||
| await once(et, 'foo'); | ||
| })().then(common.mustCall()); | ||
| test('should resolve `once` twice', (t, done) => { |
There was a problem hiding this comment.
This can be simplified as an asynchronous function, right? Calling "done" in the middle might lead to a race condition that generates extraneous asynchronous activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander “weej” Jones [email protected]