Skip to content

stream: test explicit resource management implicitly #58296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

stream: test explicit resource management implicitly #58296

wants to merge 2 commits into from

Conversation

LiviaMedeiros
Copy link
Member

In v24.x and later, we can test [Symbol.asyncDispose]() using using.

@LiviaMedeiros LiviaMedeiros added needs-ci PRs that need a full CI run. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x labels May 12, 2025
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 12, 2025
@LiviaMedeiros LiviaMedeiros added the test Issues and PRs related to the tests. label May 12, 2025
lpinca

This comment was marked as duplicate.

Sign in to view

lpinca
lpinca reviewed May 12, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (6184730) to head (2b63b3d).
Report is 46 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58296      +/-   ##
==========================================
+ Coverage   90.18%   90.22%   +0.04%     
==========================================
  Files         631      633       +2     
  Lines      186690   186836     +146     
  Branches    36666    36680      +14     
==========================================
+ Hits       168360   168569     +209     
+ Misses      11126    11074      -52     
+ Partials     7204     7193      -11

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed May 12, 2025
View reviewed changes
aduh95
aduh95 reviewed May 12, 2025
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66815/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66826/

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2025
@nodejs-github-bot
Copy link
Collaborator

Landed in 41b9263...c7b1841

nodejs-github-bot pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @nodejs-github-bot
tools: support explicit resource management in eslint
e2cf695 
PR-URL: #58296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @nodejs-github-bot
stream: test explicit resource management implicitly
c7b1841 
PR-URL: #58296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2025
@LiviaMedeiros @targos
tools: support explicit resource management in eslint
208d6a5 
PR-URL: #58296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2025
@LiviaMedeiros @targos
stream: test explicit resource management implicitly
3caa2f7 
PR-URL: #58296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LiviaMedeiros @nodejs-github-bot @jasnell @lpinca @aduh95