Skip to content

stream: test explicit resource management implicitly #58296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Member

In v24.x and later, we can test [Symbol.asyncDispose]() using using.

@LiviaMedeiros LiviaMedeiros added needs-ci PRs that need a full CI run. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. labels May 12, 2025
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 12, 2025
@LiviaMedeiros LiviaMedeiros added the test Issues and PRs related to the tests. label May 12, 2025
lpinca

This comment was marked as duplicate.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (6184730) to head (2b63b3d).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58296      +/-   ##
==========================================
+ Coverage   90.18%   90.22%   +0.04%     
==========================================
  Files         631      633       +2     
  Lines      186690   186836     +146     
  Branches    36666    36680      +14     
==========================================
+ Hits       168360   168569     +209     
+ Misses      11126    11074      -52     
+ Partials     7204     7193      -11     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants