-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
stream: test explicit resource management implicitly #58296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LiviaMedeiros
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
LiviaMedeiros:stream-test-erm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
May 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58296 +/- ##
==========================================
+ Coverage 90.18% 90.22% +0.04%
==========================================
Files 631 633 +2
Lines 186690 186836 +146
Branches 36666 36680 +14
==========================================
+ Hits 168360 168569 +209
+ Misses 11126 11074 -52
+ Partials 7204 7193 -11 🚀 New features to boost your workflow:
|
aduh95
reviewed
May 12, 2025
aduh95
reviewed
May 12, 2025
jasnell
approved these changes
May 12, 2025
4c98da4
to
2b63b3d
Compare
lpinca
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v23.x
PRs that should not land on the v23.x-staging branch and should not be released in v23.x.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v24.x and later, we can test
[Symbol.asyncDispose]()
usingusing
.