Skip to content

Update url.md #58300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update url.md #58300

wants to merge 1 commit into from
+3 −1

Conversation

dscotese
Copy link

Clarified parseQueryString and its default when omitted (but only under orlObject.query - there may be other places that need this clarification).

@dscotese
Update url.md
3b55863 
Clarified parseQueryString and its default when omitted (but only under orlObject.query - there may be other places that need this clarification).
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels May 12, 2025
jasnell
jasnell requested changes May 12, 2025
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really seeing how this change is an improvement.

@dscotese
Copy link
Author

Not really seeing how this change is an improvement.

I can see how you might not be able to take the perspective I had before I had searched the docs for a while. With some help from an AI, I realized that I hadn't adequately parsed the name of the argument. Once I did, I figure it would be a service to others who also take that perspective. I think part of our mission should be to make coders less dependent on AI.

@aduh95
Copy link
Contributor

aduh95 commented May 13, 2025

I think part of our mission should be to make coders less dependent on AI.

The paragraph you're amending was written 8 years ago, long before LLMs were a thing that devs would use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dscotese @aduh95 @jasnell @nodejs-github-bot