-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js #58573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pr4j3sh for helping the project :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58573 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 635 635
Lines 187484 187494 +10
Branches 36842 36837 -5
=======================================
+ Hits 169146 169158 +12
+ Misses 11110 11108 -2
Partials 7228 7228
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Before this can land, could you please change the commit message to adhere to the commit message guidelines, which require that the commit message title begins with the subsystem followed by an imperative verb?
In other words, use doc: fix ...
instead of doc: fixed ...
.
Thank you.
PR for #58572
Fixed definition of
assert.ifError()
in `lib/assert.js