Skip to content

doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js #58573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pr4j3sh
Copy link

@pr4j3sh pr4j3sh commented Jun 4, 2025

PR for #58572

Fixed definition of assert.ifError() in `lib/assert.js

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Jun 4, 2025
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pr4j3sh for helping the project :)

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (1093f38) to head (d5eecae).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58573   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         635      635           
  Lines      187484   187494   +10     
  Branches    36842    36837    -5     
=======================================
+ Hits       169146   169158   +12     
+ Misses      11110    11108    -2     
  Partials     7228     7228           
Files with missing lines Coverage Δ
lib/assert.js 99.51% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before this can land, could you please change the commit message to adhere to the commit message guidelines, which require that the commit message title begins with the subsystem followed by an imperative verb?

In other words, use doc: fix ... instead of doc: fixed ....

Thank you.

@pr4j3sh pr4j3sh changed the title [Docs] Fixed jsdoc definition of assert.ifError() fn in lib/assert.js doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js Jun 4, 2025
@UlisesGascon UlisesGascon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants