node-api: preserve URL filenames without conversion

[mertcanaltin]

allows us to process filenames that are already URLs by passing them unchanged

[nodejs-github-bot]

Review requested:

• @nodejs/node-api

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (641653b) to head (6b50c57).
Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_api.cc	40.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58578      +/-   ##
==========================================
- Coverage   90.21%   90.14%   -0.07%     
==========================================
  Files         635      636       +1     
  Lines      187494   187895     +401     
  Branches    36838    36879      +41     
==========================================
+ Hits       169144   169375     +231     
- Misses      11145    11287     +142     
- Partials     7205     7233      +28     

Files with missing lines	Coverage Δ
src/node_api.cc	75.91% <40.00%> (-0.26%)	⬇️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

This is not a valid way to test whether the input is a URL or not

[mertcanaltin]

@addaleax thanks, I wonder if using node::url::URL::Parse() would be a good solution here

[mertcanaltin]

Hello @anonrig

We're trying to improve URL detection in module loading. Currently using:
if (filename_view.find("://") != std::string_view::npos)

Would ada::can_parse(filename_view) be a better/healthier approach here?

Context: We need to distinguish between file paths and URLs to decide whether to:

• Use the string directly (if URL)
• Convert via node::url::FromFilePath() (if file path)

[anonrig]

Yes you can use can parse to check if an input is url.

[mertcanaltin]

thanks I will use this