test: mark timeouts & flaky test as flaky on IBM i #58583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Underlying issues still need to be investigated but this will prevent these failures from failing the daily builds. Timeouts: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network Flaky test: - parallel.test-process-cpuUsage
abmusse
force-pushed
the
ibmi-mark-timeouts-flaky
branch
from
90d32a5 to
27c2c7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58583 +/- ##
==========================================
- Coverage 90.20% 90.19% -0.01%
==========================================
Files 635 635
Lines 187501 187501
Branches 36839 36841 +2
==========================================
- Hits 169133 169121 -12
- Misses 11146 11148 +2
- Partials 7222 7232 +10 🚀 New features to boost your workflow:
|
joyeecheung
approved these changes
Jun 5, 2025
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jun 5, 2025
lpinca
approved these changes
Jun 5, 2025
richardlau
added
the
fast-track
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
richardlau
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 25f2f27 |
targos
pushed a commit
that referenced
this pull request
Jun 6, 2025
Underlying issues still need to be investigated but this will prevent these failures from failing the daily builds. Timeouts: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network Flaky test: - parallel.test-process-cpuUsage PR-URL: #58583 Refs: #58582 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying issues still need to be investigated
but this will prevent these failures from failing
the daily builds.
Timeouts:
Flaky test:
Refs: #58582
CC @nodejs/platform-ibmi