lib: bypass delay in AbortSignal.timeout

[himself65]

Fixes: #58592

setTimeout should check for if delay is valid

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (02a1505) to head (83f5055).
Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58594      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.02%     
==========================================
  Files         635      635              
  Lines      187513   187511       -2     
  Branches    36840    36813      -27     
==========================================
- Hits       169176   169154      -22     
- Misses      11106    11134      +28     
+ Partials     7231     7223       -8     

Files with missing lines	Coverage Δ
lib/internal/abort_controller.js	98.26% <ø> (-0.01%)	⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67324/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58594
✔  Done loading data for nodejs/node/pull/58594
----------------------------------- PR info ------------------------------------
Title      lib: bypass `delay` in AbortSignal.timeout (#58594)
Author     Alex Yang <[email protected]> (@himself65)
Branch     himself65:himself65/2025/06/06/timer -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - lib: bypass `delay` in AbortSignal.timeout
Committers 1
 - Alex Yang <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58594
Fixes: https://github.com/nodejs/node/issues/58592
Reviewed-By: Jake Yuesong Li <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58594
Fixes: https://github.com/nodejs/node/issues/58592
Reviewed-By: Jake Yuesong Li <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 06 Jun 2025 02:54:17 GMT
   ✔  Approvals: 1
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/58594#pullrequestreview-2907023450
   ✘  This PR needs to wait 118 more hours to land (or 0 hours if there is one more approval)
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-06-08T02:12:11Z: https://ci.nodejs.org/job/node-test-pull-request/67324/
- Querying data for job/node-test-pull-request/67324/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/15514793432

[panva]

PRs need two reviews to be landable after 48 hours. With one review a 7 day wait period is observed. A passing CI is also required.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67328/

[panva]

cc @nodejs/web-standards

[panva]

The delay argument should be validated per its WebIDL as unsigned long long, so the test vectors are incorrect.

const { convertToInt } = require('internal/webidl');

// ...

static timeout(delay) {
  const opts = { __proto__: null, enforceRange: true };
  delay = convertToInt('delay', delay, 64, opts);
  // ...
}

When done i'd suggest to change the PR title and commit message to

lib: validate AbortSignal.timeout delay per its WebIDL definition

You can also pull in the latest WPTs for AbortSignal with the following (requires https://github.com/nodejs/node-core-utils)

git node wpt dom/abort

and update test/wpt/status/dom/abort.json as such

{
  "timeout-shadowrealm.any.js": {
    "skip": "ShadowRealm support is not enabled"
  }
}