fs: special input -1 on chown, lchown and fchown
#58836
Open
+126
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
I didn't see any test about valid input in chown. well do we need add one? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58836 +/- ##
==========================================
- Coverage 90.08% 90.07% -0.01%
==========================================
Files 640 640
Lines 188375 188447 +72
Branches 36939 36966 +27
==========================================
+ Hits 169698 169745 +47
- Misses 11397 11405 +8
- Partials 7280 7297 +17
🚀 New features to boost your workflow:
|
himself65
force-pushed
the
himself65/2025/06/25/loose
branch
from
f912834 to
6fa93e5
Compare
himself65
changed the title
-1 input on chown-1 on chown, lchown and fchown
himself65
force-pushed
the
himself65/2025/06/25/loose
branch
from
74479c1 to
64f6f95
Compare
joyeecheung
reviewed
Jun 26, 2025
himself65
force-pushed
the
himself65/2025/06/25/loose
branch
from
64f6f95 to
0a3e989
Compare
joyeecheung
approved these changes
Jun 27, 2025
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
addaleax
reviewed
Jun 27, 2025
| CHECK(value->IsUint32()); | ||
| } else { | ||
| CHECK(value->IsNumber()); | ||
| } | ||
| return static_cast<T>(value.As<v8::Uint32>()->Value()); |
There was a problem hiding this comment.
Pretty sure that at least according to the V8 API contract, IsUint32() is a prerequisite for this case to be valid in the first place – overall, I'd say it's better to handle these values in the *Chown functions rather than in the generic helpers here
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
himself65
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58836 ✔ Done loading data for nodejs/node/pull/58836 ----------------------------------- PR info ------------------------------------ Title fs: special input `-1` on `chown`, `lchown` and `fchown` (#58836) Author Alex Yang <[email protected]> (@himself65) Branch himself65:himself65/2025/06/25/loose -> nodejs:main Labels c++, fs, needs-ci Commits 1 - fs: special input `-1` on `chown`, `lchown` and `fchown` Committers 1 - Alex Yang <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58836 Fixes: https://github.com/nodejs/node/issues/58826 Reviewed-By: Joyee Cheung <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58836 Fixes: https://github.com/nodejs/node/issues/58826 Reviewed-By: Joyee Cheung <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Jun 2025 17:35:29 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/58836#pullrequestreview-2965372044 ✘ This PR needs to wait 116 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-27T20:21:59Z: https://ci.nodejs.org/job/node-test-pull-request/67691/ - Querying data for job/node-test-pull-request/67691/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15936207250 |
himself65
added
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58826
-1is a special input for chown, means won't change anything according to the spec.https://stackoverflow.com/questions/21370094/is-the-uid-t-type-signed-or-unsigned