Skip to content

test: add fs.rmSync regression test for Unicode filename crash on Windows #58884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nabeel378
Copy link

Adds a regression test for a Windows-specific bug where fs.rmSync('速') crashes without throwing, observed in Node.js v23.3.0.

  • Reproduces the issue in a controlled test.
  • Skips the test on non-Windows platforms.
  • Does not crash on older versions or Linux/macOS.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 29, 2025
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (04cb572) to head (0836b0e).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58884      +/-   ##
==========================================
+ Coverage   90.07%   90.10%   +0.02%     
==========================================
  Files         640      640              
  Lines      188262   188493     +231     
  Branches    36912    36966      +54     
==========================================
+ Hits       169580   169842     +262     
+ Misses      11399    11358      -41     
- Partials     7283     7293      +10     

see 67 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/15994275556

@StefanStojanovic
Copy link
Contributor

Hey @nabeel378, thanks for the effort. From what I understand, this test will fail with the current Node.js implementation - it will not throw an error, and asserting fs.existsSync will fail. Correct?

@nabeel378
Copy link
Author

nabeel378 commented Jul 1, 2025

Hey @nabeel378, thanks for the effort. From what I understand, this test will fail with the current Node.js implementation - it will not throw an error, and asserting fs.existsSync will fail. Correct?

HI @StefanStojanovic,
Yes , it should throw an error. This is related to issue #56049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants