Skip to content

Conversation

legendecas
Copy link
Member

By default, the total buffered payloads are limited to 100MB, and 5MB
for each single request. The oldest unused requests will be evicted
first when the buffer size limit has been exceeded.

Refs: https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-enable

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 12, 2025
@legendecas legendecas force-pushed the inspector-network-buffer branch from 5a1a149 to 4ba9548 Compare October 12, 2025 17:43
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Oct 12, 2025
By default, the total buffered payloads are limited to 100MB, and 5MB
for each single request. The oldest unused requests will be evicted
first when the buffer size limit has been exceeded.
@legendecas legendecas force-pushed the inspector-network-buffer branch from 4ba9548 to c6a8b97 Compare October 12, 2025 17:49
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (f9fcc74) to head (c6a8b97).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/network_agent.cc 87.87% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60236      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.02%     
==========================================
  Files         704      704              
  Lines      208125   208218      +93     
  Branches    40003    40015      +12     
==========================================
+ Hits       184332   184381      +49     
- Misses      15809    15863      +54     
+ Partials     7984     7974      -10     
Files with missing lines Coverage Δ
src/inspector/network_requests_buffer.h 100.00% <100.00%> (ø)
src/inspector/network_agent.cc 63.48% <87.87%> (+<0.01%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants