Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #7234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Nov 16, 2024

Description

This PR updates all dependencies to the latest versions they support.

Note that ESLint is intentionally kept at 9.14.0 instead of 9.15.0, see #7232 (comment)

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@RedYetiDev RedYetiDev requested a review from a team as a code owner November 16, 2024 01:33
Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 16, 2024 2:50pm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • apps/site/package.json: Language not supported
  • package.json: Language not supported
  • packages/i18n/package.json: Language not supported
@bmuenzenmeyer
Copy link
Collaborator

@RedYetiDev in case you were unaware, there is some tenuous intentionality to our dependency pinning

https://github.com/nodejs/nodejs.org/blob/main/DEPENDENCY_PINNING.md

I have always been in the camp that we should pin ALL of them, but you don't win em all 😉

@RedYetiDev
Copy link
Member Author

I was aware. According to that document, "^" and "~" are both used, but I'll revert that change (if something changes, there can always be a follow up)

@ovflowd
Copy link
Member

ovflowd commented Nov 16, 2024

I was aware. According to that document, "^" and "~" are both used, but I'll revert that change (if something changes, there can always be a follow up)

Yup please revert the ^ to ~

apps/site/package.json Outdated Show resolved Hide resolved
@RedYetiDev
Copy link
Member Author

I'm working on updating the packages, but I'm having some errors, so I'm figuring out which dep to not update:

apps/site/components/Common/Search/States/WithSearchBox.tsx:56:13 - error TS2345: Argument of type 'Dispatch<SetStateAction<SearchResults>>' is not assignable to parameter of type '(value: Nullable<Results<DocumentType>>) => void | PromiseLike<void>'.
  Types of parameters 'value' and 'value' are incompatible.
    Type 'Nullable<Results<DocumentType>>' is not assignable to type 'SetStateAction<SearchResults>'.
      Type 'Results<DocumentType>' is not assignable to type 'SetStateAction<SearchResults>'.
        Type 'Results<DocumentType>' is not assignable to type 'Results<SearchDoc>'.
          Type 'DocumentType' is missing the following properties from type 'SearchDoc': id, path, pageTitle, siteSection, and 2 more.

56       .then(setSearchResults)
               ~~~~~~~~~~~~~~~~

apps/site/components/Common/Search/States/WithSearchBox.tsx:77:29 - error TS2345: Argument of type 'Dispatch<SetStateAction<SearchResults>>' is not assignable to parameter of type '(value: Nullable<Results<DocumentType>>) => void | PromiseLike<void>'.
  Types of parameters 'value' and 'value' are incompatible.
    Type 'Nullable<Results<DocumentType>>' is not assignable to type 'SetStateAction<SearchResults>'.
      Type 'Results<DocumentType>' is not assignable to type 'SetStateAction<SearchResults>'.
        Type 'Results<DocumentType>' is not assignable to type 'Results<SearchDoc>'.
          Type 'DocumentType' is missing the following properties from type 'SearchDoc': id, path, pageTitle, siteSection, and 2 more.

77     getInitialFacets().then(setSearchResults).catch(setSearchError);
                               ~~~~~~~~~~~~~~~~

apps/site/components/MDX/SearchPage/index.tsx:59:26 - error TS2345: Argument of type 'Nullable<Results<DocumentType>>' is not assignable to parameter of type 'SetStateAction<SearchResults>'.
  Type 'Results<DocumentType>' is not assignable to type 'SetStateAction<SearchResults>'.
    Type 'Results<DocumentType>' is not assignable to type 'Results<SearchDoc>'.
      Type 'DocumentType' is missing the following properties from type 'SearchDoc': id, path, pageTitle, siteSection, and 2 more.

59         setSearchResults(results);
                            ~~~~~~~

apps/site/components/MDX/SearchPage/index.tsx:60:36 - error TS2345: Argument of type '(Hit | Result<DocumentType>)[]' is not assignable to parameter of type 'Hit[]'.
  Type 'Hit | Result<DocumentType>' is not assignable to type 'Hit'.
    Type 'Result<DocumentType>' is not assignable to type 'Hit'.
      Types of property 'document' are incompatible.
        Type 'DocumentType' is missing the following properties from type 'SearchDoc': id, path, pageTitle, siteSection, and 2 more.

60         setHits(hits => uniqueHits([...hits, ...(results?.hits ?? [])]));
                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 4 errors.

husky - pre-commit script failed (code 1)

@RedYetiDev
Copy link
Member Author

It was Orama. I'll do a follow-up figuring out other things that need to be changed to facilitate that update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants