Skip to content

fix(publish): don't read stories or tests #7957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

avivkeller
Copy link
Member

Nothing ever works on the first try :-/

See: https://github.com/nodejs/nodejs.org/actions/runs/16127088034/job/45506513782

Because our test files were importing a file outside of rootDir, TypeScript wanted to overwrite it, so this PR excludes the test files from TypeScript generation.

Requesting fast-track, so we can get this published.

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jul 7, 2025
@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 20:39
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 7, 2025
@avivkeller avivkeller requested a review from a team as a code owner July 7, 2025 20:39
Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 7, 2025 8:52pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TypeScript configuration for the ui-components package to exclude test and story files from compilation, preventing TypeScript from attempting to overwrite imports outside the rootDir.

  • Adds an exclude section to tsconfig.json
  • Omits .test.jsx and .stories.tsx files from compilation

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.64%. Comparing base (b44cc18) to head (cdac8c3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7957      +/-   ##
==========================================
- Coverage   73.68%   73.64%   -0.05%     
==========================================
  Files          96       96              
  Lines        8354     8354              
  Branches      219      220       +1     
==========================================
- Hits         6156     6152       -4     
- Misses       2197     2201       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

Hmmm, and the script was in the wrong directory 😓

@avivkeller
Copy link
Member Author

Before merging, let me dry-publish to make sure everything works real quick

@avivkeller
Copy link
Member Author

Okay, we should be good

@avivkeller avivkeller added this pull request to the merge queue Jul 7, 2025
@ovflowd
Copy link
Member

ovflowd commented Jul 7, 2025

I approve the fast track :)

Merged via the queue into main with commit a9bd625 Jul 7, 2025
17 checks passed
@avivkeller avivkeller deleted the fix/tsconfig-root-dir-imports branch July 7, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants