-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(publish): don't read stories or tests #7957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the TypeScript configuration for the ui-components
package to exclude test and story files from compilation, preventing TypeScript from attempting to overwrite imports outside the rootDir
.
- Adds an
exclude
section totsconfig.json
- Omits
.test.jsx
and.stories.tsx
files from compilation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7957 +/- ##
==========================================
- Coverage 73.68% 73.64% -0.05%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 220 +1
==========================================
- Hits 6156 6152 -4
- Misses 2197 2201 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Hmmm, and the script was in the wrong directory 😓 |
Before merging, let me dry-publish to make sure everything works real quick |
Okay, we should be good |
I approve the fast track :) |
Nothing ever works on the first try :-/
See: https://github.com/nodejs/nodejs.org/actions/runs/16127088034/job/45506513782
Because our test files were importing a file outside of
rootDir
, TypeScript wanted to overwrite it, so this PR excludes the test files from TypeScript generation.Requesting fast-track, so we can get this published.